Thank you very much for your question. It is our pleasure to answer it.

In the name of Allah, We praise Him, seek His help and ask for His forgiveness. Whoever Allah guides none can misguide, and whoever He allows to fall astray, none can guide them aright.

Dear brother, if the picture of a human or animal is clearly visible with all its features and details, then to make, keep and sell them would be impermissible because of the numerous authentic Hadiths of the Prophet (peace be upon him) against making images of human or animal forms.

However, if the pictures are such that they merely outline the human or animal body without detailed features or they detail the features of a particular part (such as the heart), then it will be permissible to keep, though superior to avoid, and sell them and the earnings will be Halal. (Radd al-Muhtar)

Regarding the shorts, it is haram for a man to wear them in public according to the majority interpretation. However, you can wear them at home. 

And Allah knows best.